Robert Krawitz
2017-07-05 00:15:07 UTC
It looks like the Datamax-O'Neil driver is accepting an empty
resolution, but then barfing later.
$ ./run-testpattern-2 -s -f dpl
...
datamax_oneil_I4212e
BW+Resolution=NoneNo resolution found; cannot print.
FAILED
This should fix it:
diff --git a/src/main/print-dpl.c b/src/main/print-dpl.c
index ca9f0632..8232a891 100644
--- a/src/main/print-dpl.c
+++ b/src/main/print-dpl.c
@@ -832,8 +832,6 @@ dpl_parameters (const stp_vars_t * v, const char *name,
else if (strcmp (name, "Resolution") == 0)
{
description->bounds.str = stp_string_list_create ();
- stp_string_list_add_string (description->bounds.str, "None",
- _("Default"));
description->deflt.str =
dpl_val_to_string (caps->max_resolution, dpl_resolutions,
NUM_RESOLUTIONS);
resolution, but then barfing later.
$ ./run-testpattern-2 -s -f dpl
...
datamax_oneil_I4212e
BW+Resolution=NoneNo resolution found; cannot print.
FAILED
This should fix it:
diff --git a/src/main/print-dpl.c b/src/main/print-dpl.c
index ca9f0632..8232a891 100644
--- a/src/main/print-dpl.c
+++ b/src/main/print-dpl.c
@@ -832,8 +832,6 @@ dpl_parameters (const stp_vars_t * v, const char *name,
else if (strcmp (name, "Resolution") == 0)
{
description->bounds.str = stp_string_list_create ();
- stp_string_list_add_string (description->bounds.str, "None",
- _("Default"));
description->deflt.str =
dpl_val_to_string (caps->max_resolution, dpl_resolutions,
NUM_RESOLUTIONS);
--
Robert Krawitz <***@alum.mit.edu>
*** MIT Engineers A Proud Tradition http://mitathletics.com ***
Member of the League for Programming Freedom -- http://ProgFree.org
Project lead for Gutenprint -- http://gimp-print.sourceforge.net
"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton
Robert Krawitz <***@alum.mit.edu>
*** MIT Engineers A Proud Tradition http://mitathletics.com ***
Member of the League for Programming Freedom -- http://ProgFree.org
Project lead for Gutenprint -- http://gimp-print.sourceforge.net
"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton