[Gimp-print-devel] Odd name for one of the Canon modes

[Robert Krawitz]

Line 3524 of canon-modes.h. Note that the resolution name ends in _.
That's not illegal, but it's a bit odd.

{ 600, 600,CANON_INK_CMYK,"600x600dpi_high_",N_("600x600 DPI HIGH"),INKSET(11_C6M6Y6K6_c),16,MODE_FLAG_EXTENDED_T,NULL,1.0,1.0,NULL,NULL,NULL,3},/* untested */

This particular line was last changed last month. I don't know when
it was introduced; if it was introduced prior to 5.2.12 we can't
change it, but if it was changed later, perhaps it can be renamed?

[Gernot Hassenpflug]

Post by Robert Krawitz
Line 3524 of canon-modes.h. Note that the resolution name ends in _.
That's not illegal, but it's a bit odd.
{ 600, 600,CANON_INK_CMYK,"600x600dpi_high_",N_("600x600 DPI HIGH"),INKSET(11_C6M6Y6K6_c),16,MODE_FLAG_EXTENDED_T,NULL,1.0,1.0,NULL,NULL,NULL,3},/* untested */

Hi Robert,

Post by Robert Krawitz
This particular line was last changed last month. I don't know when
it was introduced; if it was introduced prior to 5.2.12 we can't
change it, but if it was changed later, perhaps it can be renamed?

Thanks for catching this. Yes, it is new, so we can change it
(canon-media-modes had the correct name, but canon-modes had the extra
"_").
Committed the change.

Gernot Hassenpflug

[Robert Krawitz]

Post by Gernot Hassenpflug

Post by Robert Krawitz
Line 3524 of canon-modes.h. Note that the resolution name ends in _.
That's not illegal, but it's a bit odd.
{ 600, 600,CANON_INK_CMYK,"600x600dpi_high_",N_("600x600 DPI HIGH"),INKSET(11_C6M6Y6K6_c),16,MODE_FLAG_EXTENDED_T,NULL,1.0,1.0,NULL,NULL,NULL,3},/* untested */

Hi Robert,

Post by Robert Krawitz
This particular line was last changed last month. I don't know when
it was introduced; if it was introduced prior to 5.2.12 we can't
change it, but if it was changed later, perhaps it can be renamed?

Thanks for catching this. Yes, it is new, so we can change it
(canon-media-modes had the correct name, but canon-modes had the extra
"_").
Committed the change.

That mismatch presumably would have caused a problem?

[Gernot Hassenpflug]

Post by Robert Krawitz

Post by Gernot Hassenpflug

Post by Robert Krawitz
Line 3524 of canon-modes.h. Note that the resolution name ends in _.
That's not illegal, but it's a bit odd.
{ 600, 600,CANON_INK_CMYK,"600x600dpi_high_",N_("600x600 DPI HIGH"),INKSET(11_C6M6Y6K6_c),16,MODE_FLAG_EXTENDED_T,NULL,1.0,1.0,NULL,NULL,NULL,3},/* untested */

Hi Robert,

Post by Robert Krawitz
This particular line was last changed last month. I don't know when
it was introduced; if it was introduced prior to 5.2.12 we can't
change it, but if it was changed later, perhaps it can be renamed?

Thanks for catching this. Yes, it is new, so we can change it
(canon-media-modes had the correct name, but canon-modes had the extra
"_").
Committed the change.

That mismatch presumably would have caused a problem?

Yes: the mode would have been selectable in the CUPS interface, but
replaced by since it was not found in the canon-media-modes
enumeration, the driver would have replaced it with one of equivalent
quality setting, which would have been the same mode with different
name. If that mode is found not to exist either an error would occur,
or a mode of lower quality would be found next, not sure which.
Certainly, it is not fool-proof to have mode enumerations, as errors
can occur in either or both places, but I haven't managed to come up
with a better idea without a lot more recoding.

Regards,
Gernot